Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated build tool and check tool images for platform-api-operator #264

Merged
merged 1 commit into from
Nov 23, 2020
Merged

updated build tool and check tool images for platform-api-operator #264

merged 1 commit into from
Nov 23, 2020

Conversation

bitscuit
Copy link
Member

What this PR does / why we need it:

Verifying update to helm 3 #260

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

horis233
horis233 approved these changes Nov 23, 2020
View reviewed changes
Copy link

@horis233 horis233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, horis233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 6ef40cc into IBM:master Nov 23, 2020
@ibm-ci-bot
Copy link
Collaborator

@bitscuit: Updated the job-config configmap in namespace default using the following files:

  • key IBM.ibm-platform-api-operator.master.yaml using file prow/cluster/jobs/IBM/ibm-platform-api-operator/IBM.ibm-platform-api-operator.master.yaml

In response to this:

What this PR does / why we need it:

Verifying update to helm 3 #260

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bitscuit added a commit to bitscuit/test-infra that referenced this pull request Nov 24, 2020
@bitscuit
Revert "updated build tool and check tool images for platform-api-ope…
dcb3247 
…rator (IBM#264)"

This reverts commit 6ef40cc.
ibm-ci-bot pushed a commit that referenced this pull request Nov 25, 2020
@bitscuit
Revert image (#267)
7f17616 
* Revert "fix incorrect check-tool image. (#265)"

This reverts commit 023910d.

* Revert "updated build tool and check tool images for platform-api-operator (#264)"

This reverts commit 6ef40cc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morvencao morvencao morvencao left review comments

@horis233 horis233 horis233 approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

Assignees

@horis233 horis233

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitscuit @ibm-ci-bot @morvencao @horis233